Add support for 'sep' and 'end' kwonlyargs in 'print'.#113
Draft
belmarca wants to merge 4 commits intoudem-dlteam:masterfrom
Draft
Add support for 'sep' and 'end' kwonlyargs in 'print'.#113belmarca wants to merge 4 commits intoudem-dlteam:masterfrom
belmarca wants to merge 4 commits intoudem-dlteam:masterfrom
Conversation
omelancon
reviewed
Jan 21, 2022
| sep = rte_lookup_locals(rte, 'sep') | ||
| end = rte_lookup_locals(rte, 'end') | ||
|
|
||
| if not (om_isinstance(sep, class_str) or om_isinstance(sep, class_NoneType)): |
Collaborator
There was a problem hiding this comment.
It's faster to do om_is(sep, om_None) since None is a singleton.
| return sem_raise_with_message(ctx, class_TypeError, "end must be None or a string") | ||
|
|
||
| sep = OM_get_boxed_value(sep) | ||
| end = OM_get_boxed_value(end) |
Collaborator
There was a problem hiding this comment.
Careful, at this point, sep and end could be om_None in your code.
| return loop(rte, 0) | ||
| else: | ||
| runtime_print('', rte) | ||
| runtime_print('' + end, rte) |
Collaborator
There was a problem hiding this comment.
runtime_print(end, rte) should do the trick
Collaborator
|
I think we should also add tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft proposes an implementation of
sepandendkeyword args inprintstatements.Works on the online REPL, need to figure out how to test this functionality.